Add argo sync-options annotation to retain PVs#1307
Closed
dan-fernandes wants to merge 2 commits intomainfrom
Closed
Add argo sync-options annotation to retain PVs#1307dan-fernandes wants to merge 2 commits intomainfrom
dan-fernandes wants to merge 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 42 42
Lines 2741 2741
=======================================
Hits 2597 2597
Misses 144 144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dan-fernandes
temporarily deployed
to
release
GitHub Actions
Inactive
dan-fernandes
had a problem deploying
to
release
GitHub Actions
Failure
dan-fernandes
had a problem deploying
to
release
GitHub Actions
Failure
Contributor
Author
|
Closed because these sync options do not work as I thought they did. I was under the impression that they would cause the PV to be retained after the PVC was deleted. I am now under the impression that they cause the PVC to not be deleted when resources using it are deleted. I may be incorrect, but I have contacted the cloud team for further clarification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1227